Yubico Forum

...visit our web-store at store.yubico.com
It is currently Tue Jan 30, 2018 4:06 pm

All times are UTC + 1 hour




Post new topic Reply to topic  [ 5 posts ] 
Author Message
 Post subject: yubico-j bug fix
PostPosted: Wed Jul 02, 2008 1:50 pm 
Offline

Joined: Wed Jun 18, 2008 11:40 pm
Posts: 3
There seems to be a bug in the yubico-j code.

Read about it here:
http://groups.google.com/group/yubico-devel/browse_thread/thread/478b47c63fd5abb2

I have checked in fix, but if all agree about fix ok Yubico need to build and publish jar I guess.

I feel strongly about the following subject so I repeat it here:

I think Yubico should produce a set of test vectors for a key being in all possible states and
stages in life. Then it will be easy to make unit tests not only for low level libraries and across
languages. I think this should have priority.


Top
 Profile  
Reply with quote  

Share On:

Share on Facebook FacebookShare on Twitter TwitterShare on Tumblr TumblrShare on Google+ Google+

 Post subject: Re: yubico-j bug fix
PostPosted: Wed Jul 02, 2008 3:12 pm 
Offline
Site Admin
Site Admin

Joined: Tue May 06, 2008 7:22 pm
Posts: 151
aha43 wrote:
There seems to be a bug in the yubico-j code.

Read about it here:
http://groups.google.com/group/yubico-devel/browse_thread/thread/478b47c63fd5abb2

I have checked in fix, but if all agree about fix ok Yubico need to build and publish jar I guess.


Agreed. The code builds for me now, thanks. So I think we are ready to make a v1.1 release, or what do you say? Have you made any changes to any function signature, or any other backwards incompatible change? If not, the v1.1 should be a drop-in replacement. If there has been some incompatible changes, we should probably apply your fix to the v1.0 version and release a maintainance v1.0.1 release with the bug fix.

Quote:
I feel strongly about the following subject so I repeat it here:

I think Yubico should produce a set of test vectors for a key being in all possible states and
stages in life. Then it will be easy to make unit tests not only for low level libraries and across
languages. I think this should have priority.


I agree. I have this on my todo list, right now I can't seem to re-program a yubikey to use caps lock though.

Thanks,
/Simon


Top
 Profile  
Reply with quote  
 Post subject: Re: yubico-j bug fix
PostPosted: Wed Jul 02, 2008 3:17 pm 
Offline
Site Admin
Site Admin

Joined: Tue May 06, 2008 7:22 pm
Posts: 151
I did a

Code:
svn diff -r 7:47 src/com/yubico/base/|less


And I can't find any incompatible changes, but it would be great if you could confirm.

/Simon


Top
 Profile  
Reply with quote  
 Post subject: Re: yubico-j bug fix
PostPosted: Wed Jul 02, 2008 5:31 pm 
Offline

Joined: Wed Jun 18, 2008 11:40 pm
Posts: 3
The only changes I did was the fix. No signature changes.


Top
 Profile  
Reply with quote  
 Post subject: Re: yubico-j bug fix
PostPosted: Thu Jul 03, 2008 9:49 am 
Offline
Site Admin
Site Admin

Joined: Tue May 06, 2008 7:22 pm
Posts: 151
Great. I'll do a release now.

Thanks,
Simon


Top
 Profile  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 5 posts ] 

All times are UTC + 1 hour


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group