| Yubico Forum https://forum.yubico.com/ |
|
| yubico-j bug fix https://forum.yubico.com/viewtopic.php?f=8&t=127 |
Page 1 of 1 |
| Author: | aha43 [ Wed Jul 02, 2008 1:50 pm ] |
| Post subject: | yubico-j bug fix |
There seems to be a bug in the yubico-j code. Read about it here: http://groups.google.com/group/yubico-devel/browse_thread/thread/478b47c63fd5abb2 I have checked in fix, but if all agree about fix ok Yubico need to build and publish jar I guess. I feel strongly about the following subject so I repeat it here: I think Yubico should produce a set of test vectors for a key being in all possible states and stages in life. Then it will be easy to make unit tests not only for low level libraries and across languages. I think this should have priority. |
|
| Author: | Simon [ Wed Jul 02, 2008 3:12 pm ] |
| Post subject: | Re: yubico-j bug fix |
aha43 wrote: There seems to be a bug in the yubico-j code. Read about it here: http://groups.google.com/group/yubico-devel/browse_thread/thread/478b47c63fd5abb2 I have checked in fix, but if all agree about fix ok Yubico need to build and publish jar I guess. Agreed. The code builds for me now, thanks. So I think we are ready to make a v1.1 release, or what do you say? Have you made any changes to any function signature, or any other backwards incompatible change? If not, the v1.1 should be a drop-in replacement. If there has been some incompatible changes, we should probably apply your fix to the v1.0 version and release a maintainance v1.0.1 release with the bug fix. Quote: I feel strongly about the following subject so I repeat it here: I think Yubico should produce a set of test vectors for a key being in all possible states and stages in life. Then it will be easy to make unit tests not only for low level libraries and across languages. I think this should have priority. I agree. I have this on my todo list, right now I can't seem to re-program a yubikey to use caps lock though. Thanks, /Simon |
|
| Author: | Simon [ Wed Jul 02, 2008 3:17 pm ] |
| Post subject: | Re: yubico-j bug fix |
I did a Code: svn diff -r 7:47 src/com/yubico/base/|less And I can't find any incompatible changes, but it would be great if you could confirm. /Simon |
|
| Author: | aha43 [ Wed Jul 02, 2008 5:31 pm ] |
| Post subject: | Re: yubico-j bug fix |
The only changes I did was the fix. No signature changes. |
|
| Author: | Simon [ Thu Jul 03, 2008 9:49 am ] |
| Post subject: | Re: yubico-j bug fix |
Great. I'll do a release now. Thanks, Simon |
|
| Page 1 of 1 | All times are UTC + 1 hour |
| Powered by phpBB® Forum Software © phpBB Group https://www.phpbb.com/ |
|