Yubico Forum

...visit our web-store at store.yubico.com
It is currently Tue Jan 30, 2018 4:07 pm

All times are UTC + 1 hour




Post new topic Reply to topic  [ 4 posts ] 
Author Message
PostPosted: Tue Jun 10, 2008 10:55 pm 
Offline

Joined: Wed Jun 04, 2008 6:33 pm
Posts: 12
Location: Bergen, Norway
Suggestion for changes in the low level java API code:

* Major: Remove import of org.apache.log4j.Logger in Modhex.java and Display.java. Is not used and is a show stopper for any who are not
using that logging API.

* Minor: In Modhex.java: Probably ok to remove commented away line 14 and variable b on line 29 is not used.

* Minor: In Display.java: Remove not used import java.io.ByteArrayOutputStream.

* Suggestion: Write missing Java doc, and check in generated html in svn with MIME type property text/html: Can be viewed directly from
Google code project site.

* Request: Code checked out into my eclipse environment look really bad formated. Not sure of cause of this. If the cause is use hard
tabs, consider using soft tabs (spaces).

* Idea: Good idea not to assume lowercase input to the Modhex decode method?

* Request: In comments at line 17 in Pof.java refers to pof_check_*. Where do one find this, in another API? Perhaps information to bprovided in a better java doc.

* Idea/request: Would it not been user friendly to also provide the properties sessionCounter, timeStampLow, timeStampHigh and
timesUsed of Token as int values?

By the way: Well done winning against Greece tonight! Cheering for Sweden since Norway did not make it...


Top
 Profile  
Reply with quote  

Share On:

Share on Facebook FacebookShare on Twitter TwitterShare on Tumblr TumblrShare on Google+ Google+

PostPosted: Thu Jun 12, 2008 6:45 am 
Offline
User avatar

Joined: Wed May 07, 2008 5:25 pm
Posts: 110
Location: Sunnyvale, California
Very good suggestions... working in progress now...

Thanks

_________________
The YubiKey Server Guy


Top
 Profile  
Reply with quote  
PostPosted: Mon Jun 16, 2008 12:13 am 
Offline
Site Admin
Site Admin

Joined: Tue May 06, 2008 7:22 pm
Posts: 151
Actually, aha42, would you like write access to the yubico-j project? Then you can commit these changes as you want. Please propose specific patches to the mailing list first:

http://groups.google.com/group/yubico-devel

Thanks,
/Simon


Top
 Profile  
Reply with quote  
PostPosted: Mon Jun 16, 2008 9:37 am 
Offline

Joined: Wed Jun 04, 2008 6:33 pm
Posts: 12
Location: Bergen, Norway
Okey, I could probably do that.

I will post something to the group this evening probably (YubiKey still not part of my daytime job, but hope to change that :-).


Top
 Profile  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 4 posts ] 

All times are UTC + 1 hour


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group