Welcome to Yubico tech community.

Suggestion for changes in the low level java API code:

* Major: Remove import of org.apache.log4j.Logger in Modhex.java and Display.java. Is not used and is a show stopper for any who are not
using that logging API.

* Minor: In Modhex.java: Probably ok to remove commented away line 14 and variable b on line 29 is not used.

* Minor: In Display.java: Remove not used import java.io.ByteArrayOutputStream.

* Suggestion: Write missing Java doc, and check in generated html in svn with MIME type property text/html: Can be viewed directly from
Google code project site.

* Request: Code checked out into my eclipse environment look really bad formated. Not sure of cause of this. If the cause is use hard
tabs, consider using soft tabs (spaces).

* Idea: Good idea not to assume lowercase input to the Modhex decode method?

* Request: In comments at line 17 in Pof.java refers to pof_check_*. Where do one find this, in another API? Perhaps information to bprovided in a better java doc.

* Idea/request: Would it not been user friendly to also provide the properties sessionCounter, timeStampLow, timeStampHigh and
timesUsed of Token as int values?

By the way: Well done winning against Greece tonight! Cheering for Sweden since Norway did not make it...

Very good suggestions... working in progress now...

Thanks

_________________
The YubiKey Server Guy

Actually, aha42, would you like write access to the yubico-j project? Then you can commit these changes as you want. Please propose specific patches to the mailing list first:

http://groups.google.com/group/yubico-devel

Thanks,
/Simon

Okey, I could probably do that.

I will post something to the group this evening probably (YubiKey still not part of my daytime job, but hope to change that :-).